Xqt has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1323966?usp=email )
Change subject: pagefromfile: Simplify summary fallback
......................................................................
pagefromfile: Simplify summary fallback
Use short-circuit evaluation to select either a custom or translated default
summary.
Change-Id: I742d39ecbb17a32aaa147d6285b19a34f80772b2
---
M scripts/pagefromfile.py
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Xqt: Verified; Looks good to me, approved
diff --git a/scripts/pagefromfile.py b/scripts/pagefromfile.py
index 7c0d092..472c484 100755
--- a/scripts/pagefromfile.py
+++ b/scripts/pagefromfile.py
@@ -136,10 +136,8 @@
# save the content retrieved from generator
contents = getattr(page, CTX_ATTR)
- if self.opt.summary:
- comment = self.opt.summary
- else:
- comment = i18n.twtranslate(self.site, 'pagefromfile-msg')
+ comment = self.opt.summary or i18n.twtranslate(
+ self.site, 'pagefromfile-msg')
comment_top = comment + ' - ' + i18n.twtranslate(
self.site, 'pagefromfile-msg_top')
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1323966?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I742d39ecbb17a32aaa147d6285b19a34f80772b2
Gerrit-Change-Number: 1323966
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
