jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1324202?usp=email )
Change subject: speedy_delete: Reuse subject page
......................................................................
speedy_delete: Reuse subject page
Store the associated subject page once when guessing a deletion reason.
This avoids constructing and loading the same page twice.
Change-Id: I22b8dde101a060298654db7f1c6b028b77b4e535
---
M scripts/speedy_delete.py
M tests/__init__.py
A tests/speedy_delete_tests.py
3 files changed, 57 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/scripts/speedy_delete.py b/scripts/speedy_delete.py
index 02899bd..c617b7b 100755
--- a/scripts/speedy_delete.py
+++ b/scripts/speedy_delete.py
@@ -328,10 +328,13 @@
def guess_reason_for_deletion(self, page):
"""Find a default reason for speedy deletion."""
- # TODO: The following check loads the page 2 times.
- # Find a better way to do it.
- if page.isTalkPage() and (page.toggleTalkPage().isRedirectPage()
- or not page.toggleTalkPage().exists()):
+ subject_page = None
+ if page.isTalkPage():
+ subject_page = page.toggleTalkPage()
+
+ if (subject_page is not None
+ and (subject_page.isRedirectPage()
+ or not subject_page.exists())):
# This is probably a talk page that is orphaned because we
# just deleted the associated article.
reason = i18n.translate(self.site, self.talk_deletion_msg,
diff --git a/tests/__init__.py b/tests/__init__.py
index 57bbcf8..d1a6ab2 100644
--- a/tests/__init__.py
+++ b/tests/__init__.py
@@ -196,6 +196,7 @@
'reflinks',
'replacebot',
'script',
+ 'speedy_delete',
'template_bot',
'uploadscript',
'weblinkchecker',
diff --git a/tests/speedy_delete_tests.py b/tests/speedy_delete_tests.py
new file mode 100755
index 0000000..16b5d01
--- /dev/null
+++ b/tests/speedy_delete_tests.py
@@ -0,0 +1,49 @@
+#!/usr/bin/env python3
+#
+# (C) Pywikibot team, 2026
+#
+# Distributed under the terms of the MIT license.
+"""Tests for scripts/speedy_delete.py."""
+from __future__ import annotations
+
+import unittest
+from contextlib import suppress
+from types import SimpleNamespace
+from unittest import mock
+
+from scripts import speedy_delete
+from tests.aspects import TestCase
+
+
+class SpeedyBotTestCase(TestCase):
+
+ """Test the speedy deletion bot."""
+
+ net = False
+
+ def test_reuses_subject_page(self) -> None:
+ """Test that the associated subject page is reused."""
+ bot = SimpleNamespace(
+ site=SimpleNamespace(code='en'),
+ talk_deletion_msg={},
+ )
+ page = mock.Mock()
+ subject_page = page.toggleTalkPage.return_value
+ page.isTalkPage.return_value = True
+ subject_page.isRedirectPage.return_value = False
+ subject_page.exists.return_value = False
+
+ with mock.patch.object(speedy_delete.i18n, 'translate',
+ return_value='Orphaned talk page'):
+ reason = speedy_delete.SpeedyBot.guess_reason_for_deletion(
+ bot, page)
+
+ self.assertEqual(reason, 'Orphaned talk page')
+ page.toggleTalkPage.assert_called_once_with()
+ subject_page.isRedirectPage.assert_called_once_with()
+ subject_page.exists.assert_called_once_with()
+
+
+if __name__ == '__main__':
+ with suppress(SystemExit):
+ unittest.main()
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1324202?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I22b8dde101a060298654db7f1c6b028b77b4e535
Gerrit-Change-Number: 1324202
Gerrit-PatchSet: 3
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
