Xqt has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1328656?usp=email )
Change subject: site: Convert page IDs once
......................................................................
site: Convert page IDs once
Convert each page ID to an integer before filtering and stringifying it.
This avoids repeating the conversion for every valid ID.
Change-Id: Ie664a54b6d334928779c3cb4501d64e5e776ed73
---
M pywikibot/site/_generators.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Xqt: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/site/_generators.py b/pywikibot/site/_generators.py
index 11ee418..54fe872 100644
--- a/pywikibot/site/_generators.py
+++ b/pywikibot/site/_generators.py
@@ -90,7 +90,7 @@
pageids = [p.strip() for p in pageids]
# Validate pageids.
- gen = (str(int(p)) for p in pageids if int(p) > 0)
+ gen = (str(p) for p in map(int, pageids) if p > 0)
for batch in batched(filter_unique(gen), self.maxlimit):
# Store the order of the input data.
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1328656?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ie664a54b6d334928779c3cb4501d64e5e776ed73
Gerrit-Change-Number: 1328656
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
