jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1332231?usp=email )
Change subject: tests: Remove unreliable bad recipient test
......................................................................
tests: Remove unreliable bad recipient test
The test treats User.is_thankable as the server's recipient policy.
Wikimedia wikis allow thanking bots under T341388, so a bot selected
from recent changes can be thanked successfully instead of raising
invalidrecipient.
The self-thank test already covers invalidrecipient deterministically.
Change-Id: I9b835a809e83bbc7aed540987140030977ccff2b
---
M tests/thanks_tests.py
1 file changed, 0 insertions(+), 15 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/tests/thanks_tests.py b/tests/thanks_tests.py
index 1298407..bba6606 100755
--- a/tests/thanks_tests.py
+++ b/tests/thanks_tests.py
@@ -77,21 +77,6 @@
code = 'test'
write = True
- def test_bad_recipient(self) -> None:
- """Test that thanking a bad recipient causes an error."""
- site = self.get_site()
- data = site.recentchanges(total=20)
- for rev in data:
- revid = rev['revid']
- username = rev['user']
- user = User(site, username)
- if not user.is_thankable:
- break
- else:
- self.skipTest(NO_THANKABLE_REVS)
- self.assertAPIError('invalidrecipient', None, site.thank_revision,
- revid, source='pywikibot test')
-
def test_invalid_revision(self) -> None:
"""Test that passing an invalid revision ID causes an error."""
site = self.get_site()
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1332231?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I9b835a809e83bbc7aed540987140030977ccff2b
Gerrit-Change-Number: 1332231
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
