jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1332480?usp=email )
Change subject: tests: Add precision to coordinate claim
......................................................................
tests: Add precision to coordinate claim
Wikibase requires globe-coordinate values to include a numeric precision.
Supply an explicit positive precision in the valid-input edit test and remove
its expected-failure marker.
Bug: T367326
Change-Id: Ied5159fe06df3dfc4d956b77a1d90461874f7a67
---
M tests/wikibase_edit_tests.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/tests/wikibase_edit_tests.py b/tests/wikibase_edit_tests.py
index c82a15b..ae4518d 100755
--- a/tests/wikibase_edit_tests.py
+++ b/tests/wikibase_edit_tests.py
@@ -290,7 +290,6 @@
claim = item.claims['P271'][0]
self.assertEqual(claim.getTarget(), target)
- @unittest.expectedFailure # T367326
def test_Coordinate_edit(self) -> None:
"""Attempt adding a Coordinate with globe set via item."""
testsite = self.get_repo()
@@ -300,7 +299,7 @@
claim = pywikibot.page.Claim(testsite, 'P20480',
datatype='globe-coordinate')
target = pywikibot.Coordinate(site=testsite, lat=12.0, lon=13.0,
- globe_item=item)
+ precision=0.1, globe_item=item)
claim.setTarget(target)
item.addClaim(claim)
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1332480?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ied5159fe06df3dfc4d956b77a1d90461874f7a67
Gerrit-Change-Number: 1332480
Gerrit-PatchSet: 1
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
