jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1332476?usp=email )
Change subject: transwikiimport: Make summaries order-independent
......................................................................
transwikiimport: Make summaries order-independent
Build the default import summary only after parsing command-line options.
This prevents an interwiki source option from being appended to a custom
summary when the options appear in that order.
Change-Id: I7411b7f1d508d2e6009f1095042b3905e910458f
---
M scripts/transwikiimport.py
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/transwikiimport.py b/scripts/transwikiimport.py
index 8695397..dcaf149 100755
--- a/scripts/transwikiimport.py
+++ b/scripts/transwikiimport.py
@@ -172,7 +172,7 @@
correspondingnamespace = 'all'
rootpage = ''
tags = ''
- summary = 'Importing page from '
+ summary = None
overwrite = False
target = False
fullhistory = False
@@ -183,7 +183,6 @@
for arg in local_args:
if arg.startswith('-interwikisource'):
interwikisource = arg[len('-interwikisource:'):]
- summary += interwikisource
elif arg.startswith('-correspondingnamespace'):
correspondingnamespace = arg[len('-correspondingnamespace:'):]
elif arg.startswith('-rootpage'):
@@ -205,6 +204,9 @@
else:
gen_args.append(arg)
+ if summary is None:
+ summary = f'Importing page from {interwikisource}'
+
tosite = pywikibot.Site()
csrf = tosite.tokens['csrf']
fromsite = pywikibot.Site().interwiki(interwikisource)
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1332476?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I7411b7f1d508d2e6009f1095042b3905e910458f
Gerrit-Change-Number: 1332476
Gerrit-PatchSet: 3
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
