jenkins-bot has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1334791?usp=email )

Change subject: nowcommons: Reuse loaded usage list
......................................................................

nowcommons: Reuse loaded usage list

Pass the materialized using_pages list to the first ImageBot replacement pass
instead of querying the same complete image usage again.

Keep the later query so it observes references after the edits.

Change-Id: I609fe49cb22e2906db9b86c9d937e7da098b1fb4
---
M scripts/nowcommons.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Xqt: Looks good to me, approved
  jenkins-bot: Verified




diff --git a/scripts/nowcommons.py b/scripts/nowcommons.py
index cc8ad52..6c4a0a7 100755
--- a/scripts/nowcommons.py
+++ b/scripts/nowcommons.py
@@ -311,7 +311,7 @@
                         '<<default>>".'
                     )

-                    bot = ImageBot(local_file_page.using_pages(),
+                    bot = ImageBot(using_pages,
                                    local_title,
                                    commons_title,
                                    always=self.opt.replacealways,

--
To view, visit 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1334791?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I609fe49cb22e2906db9b86c9d937e7da098b1fb4
Gerrit-Change-Number: 1334791
Gerrit-PatchSet: 1
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to