jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1339810?usp=email )
Change subject: tests: Preserve threaded generator results on failure
......................................................................
tests: Preserve threaded generator results on failure
Append each yielded result before the generator raises so the producer
failure test does not depend on runtime-specific list.extend behaviour.
Bug: T437699
Change-Id: I00259ba35619fdc13805b9ebabf46728bfb28eb3
---
M tests/tools_threading_tests.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/tests/tools_threading_tests.py b/tests/tools_threading_tests.py
index 3175063..96c8761 100755
--- a/tests/tools_threading_tests.py
+++ b/tests/tools_threading_tests.py
@@ -78,7 +78,8 @@
def consume() -> None:
try:
- received.extend(generator)
+ for item in generator:
+ received.append(item)
except type(failure) as e:
errors.append(e)
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1339810?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I00259ba35619fdc13805b9ebabf46728bfb28eb3
Gerrit-Change-Number: 1339810
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
