jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1340515?usp=email )
Change subject: Fix grammar in comments and documentation
......................................................................
Fix grammar in comments and documentation
Correct "necessarily" and subject-verb agreement, and clarify the
translation filtering and interactive-shell comments.
Keep the cleanup limited to prose without changing public identifiers
or executable behavior.
Change-Id: I847bdefb921afcd50a45c080040f0471c0dc6f26
---
M pywikibot/i18n.py
M pywikibot/pagegenerators/_factory.py
M pywikibot/scripts/shell.py
M pywikibot/tools/collections.py
M tests/tools_tests.py
5 files changed, 5 insertions(+), 6 deletions(-)
Approvals:
jenkins-bot: Verified
Mahveotm: Looks good to me, approved
diff --git a/pywikibot/i18n.py b/pywikibot/i18n.py
index 624262f..eeda694 100644
--- a/pywikibot/i18n.py
+++ b/pywikibot/i18n.py
@@ -850,8 +850,7 @@
for filename in sorted(os.listdir(pathname))
if filename.endswith('.json')]
- # exclude languages does not have this specific message in that package
- # i.e. an incomplete set of translated messages.
+ # Exclude languages whose translations do not include this message.
return [lang for lang in langs
if lang != 'qqq' and _get_translation(lang, twtitle)]
diff --git a/pywikibot/pagegenerators/_factory.py
b/pywikibot/pagegenerators/_factory.py
index aed01d1..8ee34e8 100644
--- a/pywikibot/pagegenerators/_factory.py
+++ b/pywikibot/pagegenerators/_factory.py
@@ -1048,7 +1048,7 @@
.. version-changed:: 11.4.1
If preleading ``not:`` directive is given, special namespaces
``-1`` and ``-2`` are not included.
- The ``-start`` or ``-until`` parameters appends a placeholder
+ The ``-start`` or ``-until`` parameters append a placeholder
to :attr:`gens`, which indicates that a generator was
specified.
diff --git a/pywikibot/scripts/shell.py b/pywikibot/scripts/shell.py
index 88aabe5..0c3f5d8 100755
--- a/pywikibot/scripts/shell.py
+++ b/pywikibot/scripts/shell.py
@@ -47,7 +47,7 @@
print('{} arguments: {}\n' # noqa: T201
.format(warn_type, ', '.join(args)))
- # Various stuffs in Python 3.4+, such as history file.
+ # Set up interactive features such as command history.
# This is defined in the site module of the Python Standard Library,
# and usually called by the built-in CPython interactive shell.
if hasattr(sys, '__interactivehook__'):
diff --git a/pywikibot/tools/collections.py b/pywikibot/tools/collections.py
index 96f241d..ec79239 100644
--- a/pywikibot/tools/collections.py
+++ b/pywikibot/tools/collections.py
@@ -241,7 +241,7 @@
...
StopIteration
>>> gen.restart() # restart a closed generator
- >>> # also send() and throw() works
+ >>> # also send() and throw() work
>>> gen.send(None) + gen.send(None)
'Py'
>>> gen.throw(RuntimeError('Foo'))
diff --git a/tests/tools_tests.py b/tests/tools_tests.py
index 14c73d9..e821ed6 100755
--- a/tests/tools_tests.py
+++ b/tests/tools_tests.py
@@ -553,7 +553,7 @@
def test_obj_id(self) -> None:
"""Test filter_unique with objects using id as key, which fails."""
- # Two objects which may be equal do not necessary have the same id.
+ # Two objects which may be equal do not necessarily have the same id.
deduped = set()
deduper = filter_unique(self.decs, container=deduped, key=id)
self.assertIsEmpty(deduped)
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1340515?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I847bdefb921afcd50a45c080040f0471c0dc6f26
Gerrit-Change-Number: 1340515
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Mahveotm <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
