jenkins-bot has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1340628?usp=email )

Change subject: Reuse page metadata when creating interwikidata items
......................................................................

Reuse page metadata when creating interwikidata items

Read the local site's database name and current page title once, then
reuse them in the sitelink and label data. Follow the same pattern used
for the additional interwiki pages.

Change-Id: I2f42e019e7b0ba57864101dc05e630267a854061
---
M scripts/interwikidata.py
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mahveotm: Looks good to me, approved




diff --git a/scripts/interwikidata.py b/scripts/interwikidata.py
index c8fd98d..1e8c66c 100755
--- a/scripts/interwikidata.py
+++ b/scripts/interwikidata.py
@@ -115,17 +115,19 @@

     def create_item(self) -> pywikibot.ItemPage:
         """Create item in repo for current_page."""
+        dbname = self.site.dbName()
+        title = self.current_page.title()
         data = {
             'sitelinks': {
-                self.site.dbName(): {
-                    'site': self.site.dbName(),
-                    'title': self.current_page.title()
+                dbname: {
+                    'site': dbname,
+                    'title': title
                 }
             },
             'labels': {
                 self.site.lang: {
                     'language': self.site.lang,
-                    'value': self.current_page.title()
+                    'value': title
                 }
             }
         }

--
To view, visit 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1340628?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I2f42e019e7b0ba57864101dc05e630267a854061
Gerrit-Change-Number: 1340628
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Mahveotm <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to