jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1343045?usp=email )
Change subject: Reuse resolved module name in argument handling
......................................................................
Reuse resolved module name in argument handling
Use the module name already resolved for logging when checking the
generate-user-files and wrapper special cases. Avoid resolving the unchanged
caller module three times during argument handling.
Change-Id: I1facd2e714a1fd27ffa5953d7691160623a0a651
---
M pywikibot/bot.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/pywikibot/bot.py b/pywikibot/bot.py
index b963796..f6ad427 100644
--- a/pywikibot/bot.py
+++ b/pywikibot/bot.py
@@ -882,13 +882,13 @@
show_help(show_global=do_help_val == 'global')
sys.exit(0)
- if calledModuleName() != 'generate_user_files': # T261771
+ if module_name != 'generate_user_files': # T261771
try:
pywikibot.Site()
except (UnknownFamilyError, UnknownSiteError):
_exception(exc_info=False)
sys.exit(1)
- if calledModuleName() == 'wrapper':
+ if module_name == 'wrapper':
pywikibot._sites.clear()
_debug('handle_args() completed.')
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1343045?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I1facd2e714a1fd27ffa5953d7691160623a0a651
Gerrit-Change-Number: 1343045
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
