jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1343051?usp=email )
Change subject: solve_disambiguation: Reuse page titles
......................................................................
solve_disambiguation: Reuse page titles
Reuse page titles within redirect handling and link processing. Resolve
them lazily on paths that need them to avoid repeated title formatting.
Change-Id: I57866f5b2369e2b461c28c592d44ab32bc81fa24
---
M scripts/solve_disambiguation.py
1 file changed, 12 insertions(+), 6 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/scripts/solve_disambiguation.py b/scripts/solve_disambiguation.py
index c72d8dc..d83ff13 100755
--- a/scripts/solve_disambiguation.py
+++ b/scripts/solve_disambiguation.py
@@ -752,15 +752,18 @@
include = False
unlink_counter = 0
new_targets = []
+ ref_page_title = disamb_page_title = None
try:
text = ref_page.get()
except IsRedirectPageError:
+ ref_page_title = ref_page.title()
+ disamb_page_title = disamb_page.title()
pywikibot.info(
- f'{ref_page.title()} is a redirect to {disamb_page.title()}')
+ f'{ref_page_title} is a redirect to {disamb_page_title}')
if disamb_page.isRedirectPage():
target = self.opt.pos[0]
if pywikibot.input_yn(
- f'Do you want to make redirect {ref_page.title()} point '
+ f'Do you want to make redirect {ref_page_title} point '
f'to {target}?',
default=False, automatic_quit=False):
redir_text = f'#{self.site.redirect()} [[{target}]]'
@@ -772,7 +775,7 @@
else:
choice = pywikibot.input_choice(
f'Do you want to work on pages linking to '
- f'{ref_page.title()}?',
+ f'{ref_page_title}?',
[('yes', 'y'), ('no', 'n'), ('change redirect', 'c')], 'n',
automatic_quit=False)
if choice == 'y':
@@ -833,13 +836,16 @@
# Check whether the link found is to disamb_page.
try:
- if foundlink.canonical_title() != disamb_page.title():
+ disamb_page_title = (disamb_page_title
+ or disamb_page.title())
+ if foundlink.canonical_title() != disamb_page_title:
continue
except Error:
# must be a broken link
+ ref_page_title = ref_page_title or ref_page.title()
pywikibot.log('Invalid link [[{}]] in page [[{}]]'
- .format(m['title'], ref_page.title()))
+ .format(m['title'], ref_page_title))
continue
n_links += 1 # new link found: increase link counter
@@ -856,7 +862,7 @@
continue
edit = EditOption('edit page', 'e', text, match_start,
- disamb_page.title())
+ disamb_page_title)
context_option = HighlightContextOption(
'more context', 'm', text, 60, start=match_start,
end=match_end)
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1343051?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I57866f5b2369e2b461c28c592d44ab32bc81fa24
Gerrit-Change-Number: 1343051
Gerrit-PatchSet: 3
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
