jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1345316?usp=email )
Change subject: page: Join revision history table fragments
......................................................................
page: Join revision history table fragments
Collect the table header, revision rows and closing markup in a list,
then join them once. This avoids quadratic string concatenation on PyPy
when transferring or copying a page with a long revision history.
Preserve table formatting, revision order and the reverse and total
arguments passed to the revision generator.
Change-Id: I7d495e1c7dfe2cc0f79f35137b8eeceeff77332b
---
M pywikibot/page/_basepage.py
1 file changed, 8 insertions(+), 7 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/page/_basepage.py b/pywikibot/page/_basepage.py
index 0aff881..6b70f38 100644
--- a/pywikibot/page/_basepage.py
+++ b/pywikibot/page/_basepage.py
@@ -2128,14 +2128,15 @@
reverse: bool = False,
total: int | None = None):
"""Return the version history as a wiki table."""
- result = '{| class="wikitable"\n'
- result += '! oldid || date/time || username || edit summary\n'
+ table = ['{| class="wikitable"\n'
+ '! oldid || date/time || username || edit summary\n']
for entry in self.revisions(reverse=reverse, total=total):
- result += '|----\n'
- result += (f'| {entry.revid} || {entry.timestamp} || {entry.user} '
- f'|| <nowiki>{entry.comment}</nowiki>\n')
- result += '|}\n'
- return result
+ table.append(
+ '|----\n'
+ f'| {entry.revid} || {entry.timestamp} || {entry.user} '
+ f'|| <nowiki>{entry.comment}</nowiki>\n')
+ table.append('|}\n')
+ return ''.join(table)
def contributors(self,
total: int | None = None,
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1345316?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I7d495e1c7dfe2cc0f79f35137b8eeceeff77332b
Gerrit-Change-Number: 1345316
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
