Xqt has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1345347?usp=email )
Change subject: Revert "tests: verify pwb site-package console entry point"
......................................................................
Revert "tests: verify pwb site-package console entry point"
This reverts commit 73b8e0d7daecb1866b3c3e2434e1a568b3281214.
Reason for revert: test mostly fails, revert completely.
Change-Id: I2d3dd51ee3f2fe2f9877d9b3acbdc4b6bf8de523
---
M pywikibot/scripts/wrapper.py
M tests/pwb_tests.py
2 files changed, 1 insertion(+), 42 deletions(-)
Approvals:
Xqt: Verified; Looks good to me, approved
diff --git a/pywikibot/scripts/wrapper.py b/pywikibot/scripts/wrapper.py
index 8e52249..4ea366d 100755
--- a/pywikibot/scripts/wrapper.py
+++ b/pywikibot/scripts/wrapper.py
@@ -553,7 +553,7 @@
print(__doc__)
-def run() -> None:
+def run() -> None: # pragma: no cover
"""Site package entry point. Print doc if necessary.
.. version-added:: 7.0
diff --git a/tests/pwb_tests.py b/tests/pwb_tests.py
index 4da8a10..b094eef 100755
--- a/tests/pwb_tests.py
+++ b/tests/pwb_tests.py
@@ -152,47 +152,6 @@
remaining = stderr.readlines()
self.assertLength(remaining, 3) # always 3 lines remaining after list
- def test_console_scripts_entry_point(self) -> None:
- """Test that the pwb console_scripts entry point is registered.
-
- Verifies the site-package ``pwb`` entry point maps to
- :func:`pywikibot.scripts.wrapper.run` (T420109).
- """
- from importlib.metadata import entry_points
-
- eps = entry_points()
- try:
- console = eps.select(group='console_scripts')
- except AttributeError: # Python < 3.10 compatibility path
- console = eps.get('console_scripts', [])
-
- pwb_eps = [ep for ep in console if ep.name == 'pwb']
- self.assertTrue(pwb_eps, 'console_scripts entry point "pwb" not found')
- self.assertEqual(pwb_eps[0].value, 'pywikibot.scripts.wrapper:run')
- self.assertIs(pwb_eps[0].load(), wrapper.run)
-
- def test_site_package_run_entry_point(self) -> None:
- """Test wrapper.run() site-package entry point behavior (T420109)."""
- with (
- patch.object(wrapper, 'site_package', False),
- patch.object(wrapper, 'execute', return_value=False) as execute,
- patch('builtins.print') as mock_print,
- ):
- wrapper.run()
- self.assertTrue(wrapper.site_package)
- execute.assert_called_once_with()
- mock_print.assert_called_once_with(wrapper.__doc__)
-
- with (
- patch.object(wrapper, 'site_package', False),
- patch.object(wrapper, 'execute', return_value=True) as execute,
- patch('builtins.print') as mock_print,
- ):
- wrapper.run()
- self.assertTrue(wrapper.site_package)
- execute.assert_called_once_with()
- mock_print.assert_not_called()
-
if __name__ == '__main__':
unittest.main(verbosity=10)
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1345347?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I2d3dd51ee3f2fe2f9877d9b3acbdc4b6bf8de523
Gerrit-Change-Number: 1345347
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Mahveotm <[email protected]>
Gerrit-Reviewer: Sanskardubey <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-CC: Chuiimuii_ofc <[email protected]>
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
