jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1361186?usp=email )
Change subject: Remove deprecated editpage bot=None compatibility
......................................................................
Remove deprecated editpage bot=None compatibility
Remove the conversion of bot=None to True deprecated in version 9.4.
Callers should pass a boolean value or use the default True value.
Document the removal under code cleanups for version 12.
Change-Id: Ifee5973281fecb09f33d16ec76281ccde20ca2b6
---
M ROADMAP.rst
M pywikibot/site/_apisite.py
2 files changed, 3 insertions(+), 7 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/ROADMAP.rst b/ROADMAP.rst
index 725cdef..f7116e9 100644
--- a/ROADMAP.rst
+++ b/ROADMAP.rst
@@ -11,7 +11,9 @@
**Code cleanups**
-* (No changes yet)
+* Remove the deprecated conversion of ``bot=None`` to ``bot=True`` in
+ :meth:`APISite.editpage()<pywikibot.site._apisite.APISite.editpage>`; use
+ a boolean value for *bot*.
**Other breaking changes**
diff --git a/pywikibot/site/_apisite.py b/pywikibot/site/_apisite.py
index b31bb65..3667887 100644
--- a/pywikibot/site/_apisite.py
+++ b/pywikibot/site/_apisite.py
@@ -77,7 +77,6 @@
deprecated,
deprecated_args,
deprecated_signature,
- issue_deprecation_warning,
merge_unique_dicts,
normalize_username,
)
@@ -2154,11 +2153,6 @@
raise
token = self.tokens['csrf']
- if bot is None:
- issue_deprecation_warning("'None' argument for 'bot' parameter",
- "'True' value", since='9.4.0')
- bot = True
-
if bot:
bot = self.has_right('bot')
# show a warning if user is a bot member but hasn't bot right
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1361186?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ifee5973281fecb09f33d16ec76281ccde20ca2b6
Gerrit-Change-Number: 1361186
Gerrit-PatchSet: 1
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
