jenkins-bot has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1365977?usp=email )

Change subject: [tests] Do not exclude conditional test skips from coverage
......................................................................

[tests] Do not exclude conditional test skips from coverage

Coverage skips conditional tests like @unittest.skipUnless or
@unittest.skipIf because '@unittest\.skip' acts as a prefix regex.
Only @unittest.skip decorated tests should be skipped.

Narrow the regex pattern to '@unittest\.skip\(' so conditional
skips are included in coverage reports.

Bug: T443260
Change-Id: I6d7a1c3e48bd2d9bf60f54a786cdea82f287afb4
---
M pyproject.toml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Xqt: Looks good to me, approved
  jenkins-bot: Verified




diff --git a/pyproject.toml b/pyproject.toml
index 7ea8932..d7f2ae7 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -134,7 +134,7 @@
 exclude_also = [
     "@(abc\\.)?abstractmethod",
     "@deprecated\\([^\\)]+\\)",
-    "@unittest\\.skip",
+    "@unittest\\.skip\\(",
     "class .+\\bProtocol\\):",
     "except (ImportError|ModuleNotFoundError)",
     "except (Quit)?KeyboardInterrupt",

--
To view, visit 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1365977?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I6d7a1c3e48bd2d9bf60f54a786cdea82f287afb4
Gerrit-Change-Number: 1365977
Gerrit-PatchSet: 2
Gerrit-Owner: KomalPandey4 <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to