jayvdb added a subscriber: jayvdb.
jayvdb added a comment.

I dont mind if this sys.exit is removed (I've been getting rid of them 
everywhere in the library), but (for the record) the use of sys.exit if 
importing httplib2 failed was introduced in 2011 over in threadedhttp.py
http://git.wikimedia.org/blobdiff/pywikibot%2Fcore.git/30c2ed6f542cb3674fa989943847e2ed916e7983/pywikibot%2Fcomms%2Fthreadedhttp.py
(prior to that it only used sys.exit if import pkg_resources failed)

Removing it does mean the users are more likely to see nasty backtraces (and 
may not notice the nice error message that we emit) if they are not using pwb.  
But IMO we should only be supporting pwb and library mode.

TASK DETAIL
  https://phabricator.wikimedia.org/T76238

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
<username>.

To: jayvdb
Cc: pywikipedia-bugs, valhallasw, jayvdb



_______________________________________________
Pywikipedia-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-bugs

Reply via email to