XZise added a comment.

Okay but I doubt the usefulness. When someone has a problem and gives the 
version number how does it help? Can I search for a file with the given hash in 
the git file history? Otherwise I don't see how that hash helps… even if you 
only want to detect if the file is changed you need to know the original hash 
and for that you need to know the version the file is in.

I'd say it should be removed any and only used where we actually have a version 
number like in `__init__.__version__` to tell the current package version (if 
that is not already done automatically). On that topic it would be probably 
helpful if the nightlies have something like '2.0b3-20150124' so we know when 
that nightly was build (and if possible maybe the short git hash just to be 
sure). But again not in every file but only in the `__init__.py` probably.


TASK DETAIL
  https://phabricator.wikimedia.org/T87409

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
<username>.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: XZise
Cc: Xqt, XZise, valhallasw, jayvdb, Aklapper, pywikipedia-bugs



_______________________________________________
Pywikipedia-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-bugs

Reply via email to