XZise added a subscriber: XZise.
XZise added a comment.

This is strange. If it's compressed it's put into a `io.StringIO` object? For 
binary data (which is what compressed data is) the `io.BytesIO` should be used. 
There is also `StringIO.StringIO` which accepts both, but was removed in Python 
3 so using that should be avoided. Maybe someone (probably me 
<https://github.com/wikimedia/pywikibot-core/commit/87df10e451a5a67fab293e18a4c98a2dd6acd925#diff-3>
 and me 
<https://github.com/wikimedia/pywikibot-core/commit/dd558f287f6e786a41a881b0956e43130260a385#diff-13>)
 has changed it from `StringIO.StringIO` to `io.StringIO` because the latter is 
available in both and they function similar. So I think there is actually a 
bug, although I'm not sure why @Mpaa hasn't experienced it. Maybe that section 
of code wasn't used.


TASK DETAIL
  https://phabricator.wikimedia.org/T86462

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
<username>.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: XZise
Cc: XZise, Mpaa, Aklapper, Rubin16, jayvdb, pywikipedia-bugs



_______________________________________________
Pywikipedia-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-bugs

Reply via email to