jayvdb added a comment. In https://phabricator.wikimedia.org/T76286#1039867, @Multichill wrote:
> Our primary python version is still 2.x. This patch shouldn't throw (tons of) > warnings when running on Python 2.x ... The current patch is ready for review; it uses DeprecationWarning which are not shown by default. > Python 2.x without the (buggy) python ipaddress library installed. The bugs in the Python 2 library are the same that exist in the Python 3 library, which have been reported upstream and received no response from python devs so far. Note that the bug does not reject valid IP addresses - i.e. any IP address which is an IP address will be detected as an IP address. The only **known** potential for a regression is that a user called "1111:2222:3333:4444:5555:6666:00.00.00.00" could be considered an IP address instead of a user, and AFAIK the MW title algorithm doesnt allow colon (:) in usernames so that isnt a problem. If you can see any potential for actual regressions, please raise them. TASK DETAIL https://phabricator.wikimedia.org/T76286 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Multichill, gerritbot, jayvdb, Ricordisamoa, XZise, pywikipedia-bugs _______________________________________________ Pywikipedia-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikipedia-bugs
