[email protected] ha scritto:
> Revision: 8292
[...]
> Log Message:
> -----------
> bugfix for r8051 (bug #3015645)
[...]
>  def skip_section(text):
> -    l = list()
> -    for s in sections_to_skip.itervalues():
> -        l.extend(s)
> -    sect_titles = '|'.join(l)
> -
> +    sect_titles = '|'.join(sections_to_skip[wikipedia.getSite().lang])
>      sectC = re.compile('(?mi)^==\s*(' + sect_titles + ')\s*==')
> -    newtext = ''
> -

Preliminary remarks: I don't work anymore in this project because 
lacking of coordination and my advises for cooperation got ignored and 
even bad interpreted as impolite requests. Of course it isn't a serious 
loss for the team.

I don't know what you wanted fix here (maybe the problem was recently 
added 'ar' row in dictionary only), but this commit is wrong.
This function should skip all the sections listed in the dictionary,
without language based distintion.

Yes, I know, this source is badly written and need a rewrite, as well
as a bad example for commit messages quality and so on, but sometime
something are made in a way for a reason.

Thanks for taking care of my script though.

Regards,
-- 
Francesco Cosoleto

La maggior parte dei lussi, e molte delle cosiddette comodità, non sono 
indispensabili, ma sono anzi veri e propri ostacoli all'elevazione 
morale dell'Uomo. (Thoreau, "Walden")


_______________________________________________
Pywikipedia-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l

Reply via email to