On 31 July 2013 12:03, Dr. Trigon <[email protected]> wrote: > As I mentioned - IMHO I would start by ignoring everything that our > code does not pass at the moment and then starting to improve the code > and successively remove ignores whenever possible.
My experience with fixing several files was that it's actually better to walk through the existing code, fixing pep8's complaints or disabling checks, depending on whether the check improves the code or not. > http://www.mediawiki.org/wiki/Gerrit/Code_review#Goals > > "Tolerate idiosyncrasies where possible. Developers should feel that > their creative input is valued and preserved." > This is very true. But remember having a consistent style also has a big advantage: it makes reading the code easier because of the consistency. Thanks for your input on the issue. Merlijn
_______________________________________________ Pywikipedia-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
