-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I fully agree with Merlijn and Amir!

Though John is pointing us to some things we might have to pay
attention to:

(1) "It shoudnt be querying git on every script invocation"

Indeed you are right - this might be due to version.py imported in
wikipedia.py... Can you give me more details here in order I can
reproduce this behaviour - but I do not see this as a big problem.

(2) "I shoudnt have to set  wikipedia.setLogfileStatus(True) in all my
scripts"

Again true - and again can you give me more details please - if this
is the case, this is clearly a bug that has to be solved.

(3) Again, we have to improve the docs, any help and feedback is very
welcome here.

Greetings
DrTrigon


On 25.08.2013 13:34, Amir Ladsgroup wrote:
> We have done it recently: you can read more in 
> http://www.mediawiki.org/wiki/Manual:Pywikipediabot/Installation
> 
> 
> 
> On 8/25/13, swuensch <[email protected]> wrote:
>> Wouldn't it be possible to implement some kind of
>> plugin-strucutred addons for those special cases where you have
>> to download more, install more, do more by yourself?
>> 
>> 
>> On Sun, Aug 25, 2013 at 11:34 AM, John
>> <[email protected]> wrote:
>> 
>>> I shoudnt have to set  wikipedia.setLogfileStatus(True) in all
>>> my scripts just because someone cant be bothered to implement
>>> their logging code correctly. Moving to pre-configred git sub
>>> modules would do the same thing, without running exicutibles on
>>> windows computers. Just because someone haphazardly threw stuff
>>> together without thinking it through doesnt mean its 
>>> acceptable
>>> 
>>> 
>>> On Sun, Aug 25, 2013 at 5:23 AM, Amir Ladsgroup 
>>> <[email protected]>wrote:
>>> 
>>>> See this: http://sourceforge.net/p/pywikipediabot/bugs/1633/
>>>> 
>>>> 
>>>> The problem is we can't set all of patches for all of users.
>>>> So many people are not interested in running IRC bots or
>>>> image handling bots, so They don't need to download almost
>>>> 100M for that
>>>> 
>>>> 
>>>> Best
>>>> 
>>>> On 8/24/13, John <[email protected]> wrote:
>>>>> Another point that is really frustrating is the logging
>>>>> system that complains about not having a logger defined if
>>>>> you run any custom
>>>> scripts.
>>>>> The only way that I have found to shut this up is to enable
>>>>> logging for
>>>> all
>>>>> scripts, however I end up with thousands of log files.
>>>>> (each pid creates its own file. and if you use
>>>>> muti-processing that ends up with
>>>> thousands or
>>>>> hundreds of thousands of log files)
>>>>> 
>>>>> Also It shoudnt be querying git on every script invocation
>>>>> or at all
>>>> unless
>>>>> version.py is manually called. that kind of overhead is
>>>>> just bloat (with perhaps the exception of interwiki.py).
>>>>> 
>>>>> if externals are needed and they need to be patched the
>>>>> best thing to to would include them pre-patched in our own
>>>>> sub-module, that way you can avoid the whole can of worms
>>>>> 
>>>>> 
>>>>> On Sat, Aug 24, 2013 at 10:14 AM, Merlijn van Deen 
>>>>> <[email protected]>wrote:
>>>>> 
>>>>>> Hi John,
>>>>>> 
>>>>>> On 23 August 2013 00:36, John <[email protected]>
>>>>>> wrote:
>>>>>> 
>>>>>>> The final straw was when I just converted to Git and
>>>>>>> discovered that
>>>> he
>>>>>>> is trying to run executables.
>>>>>>> 
>>>>>> 
>>>>>> I think most of us agree using patch.exe was not the best
>>>>>> decision. However, creating a way to install dependencies
>>>>>> locally, which also
>>>> works
>>>>>> well for windows users - unfortunately, virtualenv and
>>>>>> others don't
>>>> work
>>>>>> too well for some windows workflows, I think was a
>>>>>> sensible idea.
>>>>>> 
>>>>>> 
>>>>>>> This is bloatware plain and simple I have seen the
>>>>>>> number of externals go from 2 to 17. Most of these are
>>>>>>> probably for one or two pet programs that should never
>>>>>>> have been added to the project as they are niche
>>>> programs.
>>>>>>> 
>>>>>> I don't agree on this - the number of externals that /can
>>>>>> be installed/ has increased, but the only one required is
>>>>>> BeautifulSoup. This is not different from how things were
>>>>>> before. Thanks to the new packaging system, you are only
>>>>>> asked to install them when required. Yes, they are
>>>> typically
>>>>>> for one or two scripts, but calling them 'pet programs'
>>>>>> is just
>>>> nonsense
>>>>>> - the scripts DrTrigon has added (e.g.
>>>>>> sum_disc/discussion summaries, subster/dynamic page
>>>>>> updating from an external source, catimages/smart(er) 
>>>>>> image categorization based on content) are useful tools,
>>>>>> even though Dr Trigon might be the only one running them
>>>>>> at the moment.
>>>>>> 
>>>>>> 
>>>>>>> I would really like to see things streamlined and all
>>>>>>> of the cruft removed and get back to the nice library
>>>>>>> that we had.
>>>>>>> 
>>>>>> Apart from the patch.exe issue, I', not really sure what
>>>>>> there is to streamline - the extra externals are only
>>>>>> installed on demand and the
>>>> new
>>>>>> scripts are not in the way of using other scripts.
>>>>>> 
>>>>>> Merlijn
>>>>>> 
>>>>>> _______________________________________________ 
>>>>>> Pywikipedia-l mailing list 
>>>>>> [email protected] 
>>>>>> https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>>>> 
- --
>>>> Amir
>>>> 
>>>> _______________________________________________ Pywikipedia-l
>>>> mailing list [email protected] 
>>>> https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
>>>> 
>>> 
>>> 
>>> _______________________________________________ Pywikipedia-l
>>> mailing list [email protected] 
>>> https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
>>> 
>>> 
>> 
> 
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlIeQ5IACgkQAXWvBxzBrDDJlQCcCniJoe6OKER96J9wkliISLhy
Te4Anj3N4n3eaOCzEnuY3q6RF7x4oxI/
=vF82
-----END PGP SIGNATURE-----

_______________________________________________
Pywikipedia-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l

Reply via email to