Hi Merlijn,
On Sat, Mar 29, 2014 at 2:27 PM, Merlijn van Deen <[email protected]>wrote: > Hi Amir, > > Have you looked at the patch I committed for core? The same technique > might be applicable to compat. > > I looked for your patch but I couldn't find it, what was your technique? Frankly I think complete separation of git and pywikibot (for users, not developers) fixes this utter chaos and IMO it's best way to prevent other bugs > Otherwise, you could revert the patch that broke it (which is probably one > of the last ones in > https://github.com/wikimedia/pywikibot-compat/commits/master/pywikibot/version.py) > > I didn't check who did this but I think git version numbers (and dates) are vital for debugging and bug reporting and I don't like reverting it, even though finding a solution for this bug took like 10 hours. > Merlijn > > > On 29 March 2014 00:43, Amir Ladsgroup <[email protected]> wrote: > >> I forgot to add the patch >> https://gerrit.wikimedia.org/r/121891 >> >> and If you think this way is not best way to fix this issue, let's >> discuss because I tested every other possible way >> >> >> Best >> >> >> On Sat, Mar 29, 2014 at 4:11 AM, Amir Ladsgroup <[email protected]>wrote: >> >>> Hello all, >>> As you may know due to bug >>> 61846<https://bugzilla.wikimedia.org/show_bug.cgi?id=61846>, >>> It is impossible to run pywikibot in Windows >>> >>> It was because git version control system doesn't work properly in >>> systems that git isn't installed (obviously) and decrypting txt files in >>> .git folder isn't our job >>> >>> I tried to solve by logging commits in a text fie in >>> here<http://tools.wmflabs.org/pywikibot/gitlog.txt>and when it can't be >>> determined, the bot retrieves this file, finds out >>> what is the version and adds it to cache. >>> >>> It's the patch and It hasn't been merged yet because we need to check it >>> and review it very carefully but sooner is better, So please help and test >>> this patch in you environment. I tested it on my pc which uses windows >>> (such a shame) and It worked correctly >>> >>> Best >>> -- >>> Amir >>> >>> >> >> >> -- >> Amir >> >> >> _______________________________________________ >> Pywikipedia-l mailing list >> [email protected] >> https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l >> >> > > _______________________________________________ > Pywikipedia-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l > > -- Amir
_______________________________________________ Pywikipedia-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
