On Tue, Jun 17, 2014 at 4:39 PM, Amir Ladsgroup <[email protected]> wrote: > I disagree, I wrote lots of codes that deletion is a part of them (e.g. this > [https://www.wikidata.org/wiki/User:Ladsgroup/del.py] > code for deleting items in Wikidata). > Maybe there is one usage of them in core but it has been widely used in > customized codes.
In my email .. 'only one use of' ... was referring to calling Page.delete() with mark=True, which is a code path that your code does not use, and doesnt belong in Page. The more usual use of Page.delete() is with mark=False , and I'm sure we can find a nice solution for re-using that code. Im happy with it staying in Page even, provided it is clearly documented as a highly re-used piece of logic. If someone else does use protect() or delete(mark=True) in custom code, it would be good to know about it. -- John Vandenberg _______________________________________________ Pywikipedia-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
