- **status**: open --> closed
- **Comment**:

thanks for the report, closed by [r3660].

When I ported the conf.py from Sphinx 1.2 to 1.3 I noticed that `safe_repr` has 
advanced to `object_description` and I just changed our Sphinx patch. It worked 
immediately. However, I didn't notice that Sphinx 1.3+ now already strips this 
information itself. Great, we don't need to fiddle in the details of Sphinx 
anymore!

Congratulations for this brilliant catch to notice that we still tried to do 
patch Sphinx even though it's not at all needed anymore. I probably would nave 
have tried/noticed it myself, but I failed to do so. Thanks a lot!



---

** [bugs:#63] Monkey-patching object_description is wrong**

**Status:** closed
**Group:** PyX
**Created:** Fri Jun 05, 2015 06:44 PM UTC by Dmitry Shachnev
**Last Updated:** Fri Jun 05, 2015 06:44 PM UTC
**Owner:** nobody

Hi,

Revision https://sourceforge.net/p/pyx/code/3651/ changed conf.py to 
monkey-patch `object_description` instead of `safe_repr`.

However, now that code longer makes sense. Unlike `safe_repr`, 
`object_description` strips out memory addresses using its own regex, so trying 
to match the output against a regex that contains memory address will never 
succeed. See [this 
diff](https://github.com/sphinx-doc/sphinx/commit/d24bd73d0ce80714#diff-84bfd2ad46b7c8e97e5a06abb886c065L126)
 for details.


---

Sent from sourceforge.net because [email protected] is subscribed 
to https://sourceforge.net/p/pyx/bugs/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/pyx/admin/bugs/options.  Or, if this is a mailing 
list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
_______________________________________________
PyX-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pyx-devel

Reply via email to