----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/38/#review52 -----------------------------------------------------------
Overall looks pretty good. if we can get the traceback figured out (either fix it or determine that there's something off in my dev env) let's get it merged into develop. We don't have a lot of time before F20 branches, and we did commit to moving over to fas-openid. It might be a while before a new python-fedora release is made, but the fas-openid code is already hotfixed into infra hosts and I'm planning to do the same to our dev host - Tim Flink On July 18, 2013, 9:35 a.m., Martin Krizek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-tflink.rhcloud.com/r/38/ > ----------------------------------------------------------- > > (Updated July 18, 2013, 9:35 a.m.) > > > Review request for blockerbugs. > > > Repository: blockerbugs > > > Description > ------- > > commit e08c8ee1085bb0beb71b4a5c98c9d2e2497773cb > Author: Martin Krizek <[email protected]> > Date: Mon Jul 15 11:28:09 2013 +0200 > > Use fake login only in DEV environment > > commit 8f175a28ae43b764e52435d174d73e2dc384bd6b > Author: Martin Krizek <[email protected]> > Date: Thu Jul 4 11:14:40 2013 +0200 > > Add developer login > > This patch allows a fake login when DEV or TEST is set so we don't > access FAS server each time we log in. > > TODO this will be merged with changes made in other review request dealing > with fas-openid migrations. > > > Diffs > ----- > > blockerbugs/util/login.py PRE-CREATION > blockerbugs/templates/layout.html 8dc6deacd5e7a71757ed2564fb224b3cd92bfad5 > blockerbugs/controllers/users.py 6f89a0b29143a9c09fcf25d97d875a01b9955fa4 > blockerbugs/controllers/main.py a8082121576015a86c31bc76ebc17e982062a08b > blockerbugs/__init__.py 798fc6ecd562d1e13fbba26f804f74e6da670120 > > Diff: http://reviewboard-tflink.rhcloud.com/r/38/diff/ > > > Testing > ------- > > > Thanks, > > Martin Krizek > >
_______________________________________________ qa-devel mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/qa-devel
