----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/48/#review92 -----------------------------------------------------------
Ship it! I didn't understand why you renamed the user/login and user/logout endpoints at first but using the decorator in flask_fas_openid makes a lot of sense to me. Looks good, please merge into develop - Tim Flink On Sept. 4, 2013, 7:06 p.m., Ilgiz Islamgulov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-tflink.rhcloud.com/r/48/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2013, 7:06 p.m.) > > > Review request for blockerbugs. > > > Repository: blockerbugs > > > Description > ------- > > Use "local" for request g.fas_user instead of global auth to store user > information. > > > Diffs > ----- > > blockerbugs/util/login.py 0357ed9320b1493ee68a1e2491d99fafa4654b26 > blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 > blockerbugs/controllers/users.py 7b6954adc39b23c997033916e1adc17639451fdd > blockerbugs/controllers/main.py 44924e096803b5c448dbd84dc5fe0405a97ebc50 > blockerbugs/__init__.py b9d7a40e4e9b47624795958212025428e7788b0f > > Diff: http://reviewboard-tflink.rhcloud.com/r/48/diff/ > > > Testing > ------- > > Latest > https://raw.github.com/fedora-infra/python-fedora/develop/flask_fas_openid.py > must be used. > > I've tested on my local dev instance. > 1) login in browser > 2) open blockerbugs in another browser > > Login\Logout with dev login. > > > Thanks, > > Ilgiz Islamgulov > >
_______________________________________________ qa-devel mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/qa-devel
