----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/55/#review114 -----------------------------------------------------------
blockerbugs/controllers/main.py <http://reviewboard-tflink.rhcloud.com/r/55/#comment144> I wonder if it would be better to change the configuration setting to not have the 'xmlrpc.cgi' part at the end would be a better solution. We'd have to add it in bz_interface, but I don't really like this url munging in the controller. Overall, looks good other than my question about url munging vs. changing how the settings are done. Thoughts? - Tim Flink On Oct. 11, 2013, 11:01 a.m., Martin Krizek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-tflink.rhcloud.com/r/55/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2013, 11:01 a.m.) > > > Review request for blockerbugs. > > > Bugs: t423 > https://fedorahosted.org/fedora-qa/ticket/t423 > > > Repository: blockerbugs > > > Description > ------- > > commit ddcd87dcda42b9ee17000cdac0251b0b3a7f3e28 > Author: Martin Krizek <[email protected]> > Date: Fri Oct 11 12:49:54 2013 +0200 > > Don't use hardcoded bz url in the milestone_info template > > > Diffs > ----- > > blockerbugs/templates/milestone_info.html > bac8fa075ef4fd40c95fb35885951845d483b521 > blockerbugs/controllers/main.py 5619a834b4d613398bac2cc196a1a71457af30f2 > > Diff: http://reviewboard-tflink.rhcloud.com/r/55/diff/ > > > Testing > ------- > > I tested it on my local machine. > > > Thanks, > > Martin Krizek > >
_______________________________________________ qa-devel mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/qa-devel
