On Wed, Feb 12, 2014 at 08:36:24AM -0500, Kamil Paral wrote: > At present if somebody posts a patch for review in Phab, he fills in > the Reviewers fields with some possible review candidates so that > the people are notified. Usually me, Martin and Tim appear in that > field. > > I wonder if there is a better approach. Anyone interested in doing > code reviews could set up a Herald rule to watch review requests in > the particular repository. This is my "Differential Revisions" > herald rule: > > > When all of these conditions are met: > > Repository is any of rLTRN (libtaskotron) > > Take these actions every time this rule matches: > > Send an email to kparal > > With this rule, you get notified once when the review is created, > but not on its updates (unless you choose to get CC'd or you're > specified in the Reviewers field). > > If all of us (I, Martin, Tim, Josef, Petr and anyone else > interested) set it up this way, we will be notified of incoming > review requests, and people don't need to put a large number of > names blindly into the Reviewers field. Of course they still can > some provide some names manually, to create some pressure on the > most likely reviewers :-) With this approach it's also easy to see > which reviews are "taken" and which are still free to take (empty > reviewers list). > > So, if you're just slightly interested in doing some code reviews, I > think that creating such Herald rule is a good way to follow what's > going on. At the moment it can be created just for libtaskotron, > because that's the only repository we mirror (and the rule seems to > be based on repositories, not projects). But we can easily start > mirroring repositories of other projects as well, I believe.
This sounds great.. but what is Herald? Is it a webapp? Can you link us to more instructions?
pgpkrws88bvcj.pgp
Description: PGP signature
_______________________________________________ qa-devel mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/qa-devel
