On Mon, Feb 6, 2017 at 6:19 PM, Kamil Paral <kpa...@redhat.com> wrote:
So this is about removing `_ITEM_TYPES` from `main.py`, correct? > Yes, I could have been more specific. > > I don't have a problem with that, as long as any relevant docs are updated > and we're able to present a reasonable message when something goes wrong - > either if there's a typo or the user executes a formula expecting type X > with type Y (and therefore e.g. `koji_build` variable is required but not > provided). It also means we should document the most commonly used types > somewhere, so that people know for which events they can write their tasks > and have them executed in our infra. > Agreed, I think that we can not really "stop" the execution on a "supposed typo", but some heuristics + warnings are IMO a good thing to have. I thought that the types are already documented but if not, then putting together the list of the most common ones is IMO a good idea.
_______________________________________________ qa-devel mailing list -- qa-devel@lists.fedoraproject.org To unsubscribe send an email to qa-devel-le...@lists.fedoraproject.org