> On Thu, 2017-03-02 at 04:31 -0500, Kamil Paral wrote: > > > The job can - and already does - log the exact packages it actually > > > got, but I don't think there's an easy way for it to take the > > > 'last_modified' date for the update at the time it does the download. > > > > I don't know how you download the rpms, but a single python call can > > do that (http get and parse the json). Again, to prevent race > > conditions, it would be good to do the call before and after > > downloading the rpms and compare the timestamp. These race conditions > > occur surprisingly often once you start executing hundreds/thousands > > tasks a day. > > > > But if this is easier done in the scheduler, I think that's totally fine. > > During test execution, we can only really type stuff into the console. > We try to keep the amount of typing-into-consoles we do to a minimum, > too, as the more there is, the more likely it is openQA will choke on a > keypress and fail. (Though these tests already involve quite a lot of > typing, can't avoid it.) The test just uses the Bodhi CLI client to > download the packages.
Sure, I'm not saying this needs to happen during the actual test. That seems silly, if we can do the same thing in the scheduler (initial timestamp) and in the reporter (end timestamp). > > I mean, it's not impossible, we *could* just type in a curl / Python > one-liner (or use something like httpie to hit the API to get it). I'm > just questioning whether it's worth the effort. It's not necessary now, in the "development" phase. But once we want gate on it, I think it's very important (if we want our gating mechanics to be reliable). _______________________________________________ qa-devel mailing list -- qa-devel@lists.fedoraproject.org To unsubscribe send an email to qa-devel-le...@lists.fedoraproject.org
