As I've been adding and updating automated tests for Visual Editor, I've noticed that even though we usually export a MEDIAWIKI_USER environment variable value, there is a hard-coded equivalent value defined in visual_editor_page.rb at line 5[1]

In order to move in the direction of making the tests more flexible, does anyone have concerns if I submit a change to modify that line from:

/page_url URL.url('User:Selenium_user')/

...to:
/
//page_url URL.url("User:" + ENV['MEDIAWIKI_USER'])/

Let me know if you have any concerns with such a change, otherwise I'll submit a change via Gerrit.

Thanks,

Jeff H.



1:
https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
_______________________________________________
QA mailing list
QA@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/qa

Reply via email to