I'm fine with that. It did fix the test for me running Chrome locally,
but I agree that it's a nasty fix. We might want to rewrite all confirm
dialog steps so that the action that triggers the dialog is included in
#confirm method's block.
On 04/25/2014 12:29 PM, Jon Robson wrote:
Juliusz's patch [1] doesn't seem to have fixed the Chrome builds [2].
Chris didn't like Juliusz's patch and submitted a new one [3] which
doesn't work for me either.
I think we should simplify this by
1) reverting Juliusz's change [4]
2) turning off the test for Chrome with my original patch [5] and then
take a look at the bug [6] separately.
Thoughts?
[1] https://gerrit.wikimedia.org/r/129599
[2]
https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/405/testReport/
[3] https://gerrit.wikimedia.org/r/129605
[5] https://gerrit.wikimedia.org/r/129732
[5] https://gerrit.wikimedia.org/r/#/c/129586/
[6] https://bugzilla.wikimedia.org/show_bug.cgi?id=64397
_______________________________________________
QA mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/qa
_______________________________________________
QA mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/qa
