Chris's patch got merged and this bug got opened https://bugzilla.wikimedia.org/show_bug.cgi?id=65274
Thanks a bunch Chris! On Tue, May 13, 2014 at 10:51 PM, Jon Robson <[email protected]> wrote: > The dialog can be avoided by adding meta data to the image.... > > On Tue, May 13, 2014 at 10:48 PM, Chris McMahon <[email protected]> > wrote: >> >> On Tue, May 13, 2014 at 1:22 PM, Jon Robson <[email protected]> wrote: >>> >>> Thanks for documenting this Chris! >>> >>> I'm not sure if this should be a bug - maybe uploads to >>> Special:Uploads of this form should show an error message saying "We >>> already have this photo." ? >> >> >> I am tempted to leave it the way it is and just have the test check the alt >> text of the thumbnail image rather than the href value. That would validate >> that the steps to upload are working properly. >> >>> >>> >>> That aside how can we ensure each of the images uploaded is unique? >>> This test should be testing the case where an upload is unique.. >> >> >> I tried running this test using the shared image upload code to upload >> unique(ish) images. But doing that shows a modal dialog that says "Warning! >> This photo looks suspicious. If it's not a photo that you took, please do >> not upload it. Do you still want to continue?" >> >> I also get that modal dialog uploading images manually. >> >> We could make the test dismiss the modal dialog, but it would be better if >> we did not see the modal dialog at all. >> >> -Chris >> >> >> _______________________________________________ >> Mobile-l mailing list >> [email protected] >> https://lists.wikimedia.org/mailman/listinfo/mobile-l >> > > > > -- > Jon Robson > * http://jonrobson.me.uk > * https://www.facebook.com/jonrobson > * @rakugojon -- Jon Robson * http://jonrobson.me.uk * https://www.facebook.com/jonrobson * @rakugojon _______________________________________________ QA mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/qa
