Hello, Last week I had paired with Zeljko on Monday, Tuesday, Thursday and Friday. Here is what we did on Friday:
* I had some problems in getting cropped screenshot for elements inside an iframe, reason for it was, elements which are inside iframe, return their co-ordinates with respect to the iframe rather than the browser window. * Hence to solve this we decided to pass another argument(offset_rectangle) to rectangle method which we had written before. * We wrote some tests for it and then got it passing, just by adding of x co-ordinates and y co-ordinates of the cropped screenshot with iframe co-ordinates. * One interesting thing, which we changed was the argument variable in methods, when optional we tend to make it nil, but here we used it as an empty rectangle(i.e. [0, 0, 0, 0]) so that the code becomes smaller and cleaner. Thank you Zeljko, for pairing with me last week. I had amazing time with you reviewing this code :) Now I have realized what exactly is expected when one looks into the code. Let me know if I have missed anything in last weeks reports. Regards -- Vikas S Yaligar (9481543789) IT Department NITK Surathkal
_______________________________________________ QA mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/qa
