Eric Blake <ebl...@redhat.com> writes: > On 03/03/2015 01:13 PM, Max Reitz wrote: >> Signed-off-by: Max Reitz <mre...@redhat.com> >> --- >> block.c | 2 ++ >> blockdev.c | 18 ++++++++++++++++++ >> include/block/block_int.h | 4 ++++ >> stubs/Makefile.objs | 1 + >> stubs/blockdev-close-all-bdrv-states.c | 5 +++++ >> 5 files changed, 30 insertions(+) >> create mode 100644 stubs/blockdev-close-all-bdrv-states.c > > Again, might be nice for the commit message to document why adding this > is useful, but doesn't affect the code. > > Reviewed-by: Eric Blake <ebl...@redhat.com>
Might be nice? This absolutely needs an explanation, in the code! Why do we need a separate list of "monitor-owned BDS"? What makes a BDS "monitor-owned"? What are the invariants governing relations among bdrv_states, graph_bdrv_states (what a horrible name) and blk_backends?
