From: Laszlo Ersek <[email protected]> Even if board code decides not to request the creation of the FDC (keyed off board-level factors, to be determined later), we should create the FDC nevertheless if the user passes '-drive if=floppy' on the command line.
Otherwise '-drive if=floppy' would break without explicit '-device isa-fdc' on such boards. Cc: Markus Armbruster <[email protected]> Cc: Paolo Bonzini <[email protected]> Cc: Gerd Hoffmann <[email protected]> Cc: John Snow <[email protected]> Cc: "Gabriel L. Somlo" <[email protected]> Cc: "Michael S. Tsirkin" <[email protected]> Cc: Kevin Wolf <[email protected]> Cc: [email protected] Signed-off-by: Laszlo Ersek <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> --- hw/i386/pc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index b2fc501..1eb1db0 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1490,6 +1490,7 @@ void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi, for(i = 0; i < MAX_FD; i++) { fd[i] = drive_get(IF_FLOPPY, 0, i); + create_fdctrl |= !!fd[i]; } *floppy = create_fdctrl ? fdctrl_init_isa(isa_bus, fd) : NULL; } -- MST
