Re: [Qemu-block] [PATCH v2 02/13] block: Introduce bdrv_lock and bdrv_unlock API

[Stefan Hajnoczi]

On Tue, Jun 02, 2015 at 11:21:51AM +0800, Fam Zheng wrote:
> +/**
> + * bdrv_lock:
> + *
> + * Begin a temporary exclusive accessing by locking the BDS.
> + */
> +void bdrv_lock(BlockDriverState *bs);
> +
> +/**
> + * bdrv_unlock:
> + *
> + * End a exclusive accessing.
> + */
> +void bdrv_unlock(BlockDriverState *bs);

This documentation is missing important points:

1. Does AioContext need to be held by the caller?  (Yes)

2. Is this about thread safety?  (No, it's about exclusive access to a
   BDS *within* the AioContext.)

Maybe bdrv_begin_exclusive() and bdrv_end_exclusive() are clearer names?

pgpp9mz91fSei.pgp
Description: PGP signature