On 23/07/2015 10:03, Markus Armbruster wrote: > >> > v2: >> > * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business >> > [Kevin] >> > * Print the warning in the same way as the aio=native,cache.direct=off >> > deprecation warning [Kevin] >> > >> > Open question: what about the Windows case? We now pass the >> > FILE_FLAG_OVERLAPPED flag which we didn't do before for -drive aio=native. > Odd. Commit a273652 takes the trouble to implement native asynchronous > I/O there, but unless CONFIG_LINUX_AIO somehow gets defined, it's > unreachable, isn't it? Paolo?
I don't remember how I tested that code, but it's probably been dead code since it was committed. If it's bitrot and thus these patches break it, I will fix it. Paolo > I think PATCH 2's commit message needs to be updated to discuss the > impact.
