On Thu, 09/10 11:48, Radoslav Gerganov wrote: > On 10.09.2015 11:15, Fam Zheng wrote: > > On Thu, 09/10 10:53, Radoslav Gerganov wrote: > >> When the VMDK is streamOptimized (or compressed), the > >> next_cluster_sector must not be incremented by a fixed number of > >> sectors. Instead of this, it must be rounded up to the next consecutive > >> sector. Fixing this results in much smaller compressed images. > >> > >> Signed-off-by: Radoslav Gerganov <[email protected]> > > > > Is this patch enough to produce a valid streamOptimized image? Because I > > remember there were reports on some other issues with footer or grain > > markers. > > > > Fam > > The VMDK spec says that each marker and its associated block must begin on > sector boundary which is true before and after my patch. However, with my > patch we don't put empty sectors when we achieve good compression for the > current cluster but start the next cluster on the next consecutive sector. > > I have also verified that images produced with my patch can be booted in > VMware Workstation.
Thanks, the change looks good to me. Reviewed-by: Fam Zheng <[email protected]>
