Re: [Qemu-block] [PATCH 3/3] block: prohibit migration during transactions

[Paolo Bonzini]

On 01/10/2015 18:34, John Snow wrote:
> +
> +    error_setg(&blocker, "Block device(s) are in use by a Block 
> Transaction");

s/Block Transaction/transaction command/

But how can migration start during a transaction?

> +    ret = migrate_add_blocker(blocker, errp);
> +    if (ret < 0) {
> +        goto cleanup_mig;
> +    }
>  
>      QSIMPLEQ_HEAD(snap_bdrv_states, BlkTransactionState) snap_bdrv_states;
>      QSIMPLEQ_INIT(&snap_bdrv_states);
> @@ -1814,6 +1823,9 @@ exit:
>          }
>          g_free(state);
>      }
> + cleanup_mig:
> +    migrate_del_blocker(blocker);
> +    error_free(blocker);