Re: [Qemu-block] [PATCH 01/17] crypto: add QCryptoSecret object class for password/key handling

[Paolo Bonzini]

On 19/10/2015 17:09, Daniel P. Berrange wrote:
> +
> +    switch (secret->format) {
> +    case QCRYPTO_SECRET_FORMAT_UTF8:
> +        if (!g_utf8_validate(input, strlen(input), NULL)) {
> +            error_setg(errp,
> +                       "Data from secret %s is not valid UTF-8",
> +                       secretid);
> +            goto cleanup;
> +        }
> +        output = input;
> +        input = NULL;
> +        break;

Why validate secrets as UTF-8?  In other words why have "utf8" instead
of "binary" as a possible QCryptoSecretFormat?

Paolo