On 11/09/2015 10:54 PM, Alberto Garcia wrote:
> On Fri 16 Oct 2015 10:57:46 AM CEST, Wen Congyang wrote:
>
>> + .name = "blockdev_change",
>> + .args_type = "op:s,parent:B,child:B?,node:?",
>> + .params = "operation parent [child] [node]",
> [...]
>> + /*
>> + * FIXME: we must specify the parameter child, otherwise,
>> + * we can't specify the parameter node.
>> + */
>> + if (op == CHANGE_OPERATION_ADD) {
>> + has_child = false;
>> + }
>
> So if you want to perform the 'add' operation you must pass both 'child'
> and 'node' but the former will be discarded.
>
> I don't think you really need to do this for the HMP interface, but it's
> anyway one more good reason to merge 'child' and 'node'.
Do you mean there is no need to implement the HMP interface?
Thanks
Wen Congyang
>
> Berto
> .
>
