Re: [Qemu-block] [PATCH] block: make 'stats-intervals' a list of integers

[Stefan Hajnoczi]

On Wed, Nov 11, 2015 at 03:17:12PM +0200, Alberto Garcia wrote:
> This is the natural JSON representation and prevents us from having to
> decode the list manually.
> 
> Signed-off-by: Alberto Garcia <be...@igalia.com>
> ---
>  blockdev.c             | 64 
> ++++++++++++++++++++++++++++++++++----------------
>  qapi/block-core.json   |  7 +++---
>  tests/qemu-iotests/136 |  2 +-
>  3 files changed, 48 insertions(+), 25 deletions(-)

gcc 5.1.1 warning:

blockdev.c: In function ‘blockdev_init’:
blockdev.c:636:17: error: ‘length’ may be used uninitialized in this function 
[-Werror=maybe-uninitialized]
                 block_acct_add_interval(blk_get_stats(blk), length);
                 ^
blockdev.c:597:22: note: ‘length’ was declared here
             unsigned length;
                      ^

signature.asc
Description: PGP signature