On 10/12/2015 03:59, Zhu Lingshan wrote: > - if (task == NULL || task->status != SCSI_STATUS_GOOD) { > + if ((rc16 != NULL) && ((task == NULL) || (task->status != > SCSI_STATUS_GOOD))) { > + error_setg(errp, "iSCSI: failed to send readcapacity16 command."); > + }
You need an "else" here. Paolo > + if ((rc10 != NULL) && ((task == NULL) || (task->status != > SCSI_STATUS_GOOD))) { > error_setg(errp, "iSCSI: failed to send readcapacity10 command."); > } else if (!iscsilun->block_size ||