Hi In this v2: - the first two patches are included on the last pull request. - Changed copyright from Anthony to Orit (thanks David) Some archeology required. - Get all the reviews by from Vladimir. - Rebased on top of my last pull request.
The first two patches don't belong in this series, but without them I got lots of confilcts if you try to use the series. That two patches are independently on the list. Please review. [v1] This series move to options.c: - all migration capabilities code - all migration parameters code - all properties code - all qmp commands that only touch the previous And once there: - sort of functions - make consistent and coherent all the functions naming/typing - create accessors for the parameters/capabilties that don't exist - more cleanups here and there. Todo: - There is still capabilities code on savevm.c, but I want this in before moving that code to options.c, but still needs more thought for my part. I.e. should I put vmstate sections in options.c, or should I create new functions to access the capabilities in savevm.c. Please review. Juan Quintela (43): migration: move migration_global_dump() to migration-hmp-cmds.c spice: move client_migrate_info command to ui/ migration: Create migration_cap_set() migration: Create options.c migration: Move migrate_colo_enabled() to options.c migration: Move migrate_use_compression() to options.c migration: Move migrate_use_events() to options.c migration: Move migrate_use_multifd() to options.c migration: Move migrate_use_zero_copy_send() to options.c migration: Move migrate_use_xbzrle() to options.c migration: Move migrate_use_block() to options.c migration: Move migrate_use_return() to options.c migration: Create migrate_rdma_pin_all() function migration: Move migrate_caps_check() to options.c migration: Move qmp_query_migrate_capabilities() to options.c migration: Move qmp_migrate_set_capabilities() to options.c migration: Move migrate_cap_set() to options.c migration: Move parameters functions to option.c migration: Use migrate_max_postcopy_bandwidth() migration: Move migrate_use_block_incremental() to option.c migration: Create migrate_throttle_trigger_threshold() migration: Create migrate_checkpoint_delay() migration: Create migrate_max_cpu_throttle() migration: Move migrate_announce_params() to option.c migration: Create migrate_cpu_throttle_initial() to option.c migration: Create migrate_cpu_throttle_increment() function migration: Create migrate_cpu_throttle_tailslow() function migration: Move migrate_use_tls() to options.c migration: Move migrate_postcopy() to options.c migration: Create migrate_max_bandwidth() function migration: Move qmp_query_migrate_parameters() to options.c migration: Move qmp_migrate_set_parameters() to options.c migration: Create migrate_params_init() function migration: Make all functions check have the same format migration: Create migrate_downtime_limit() function migration: Move migrate_set_block_incremental() to options.c migration: Move block_cleanup_parameters() to options.c migration: Remove MigrationState from block_cleanup_parameters() migration: Create migrate_tls_creds() function migration: Create migrate_tls_authz() function migration: Create migrate_tls_hostname() function migration: Create migrate_block_bitmap_mapping() function migration: Move migration_properties to options.c hw/virtio/virtio-balloon.c | 1 + include/migration/misc.h | 1 - migration/block-dirty-bitmap.c | 15 +- migration/block.c | 5 +- migration/colo.c | 6 +- migration/meson.build | 1 + migration/migration-hmp-cmds.c | 40 +- migration/migration.c | 1352 +------------------------------- migration/migration.h | 42 - migration/multifd-zlib.c | 1 + migration/multifd-zstd.c | 1 + migration/multifd.c | 24 +- migration/options.c | 1318 +++++++++++++++++++++++++++++++ migration/options.h | 106 +++ migration/postcopy-ram.c | 1 + migration/ram.c | 43 +- migration/rdma.c | 12 +- migration/savevm.c | 3 +- migration/socket.c | 5 +- migration/tls.c | 23 +- qapi/migration.json | 28 - qapi/ui.json | 28 + ui/ui-hmp-cmds.c | 17 + ui/ui-qmp-cmds.c | 29 + 24 files changed, 1619 insertions(+), 1483 deletions(-) create mode 100644 migration/options.c create mode 100644 migration/options.h -- 2.39.2
