Re: [PATCH 05/13] hw/ide: Extract pci_ide_class_init()

[Bernhard Beschow]

Am 23. April 2023 17:41:33 UTC schrieb "Philippe Mathieu-Daudé" 
<phi...@linaro.org>:
>On 22/4/23 17:07, Bernhard Beschow wrote:
>> Resolves redundant code in every PCI IDE device model.
>> ---
>>   include/hw/ide/pci.h |  1 -
>>   hw/ide/cmd646.c      | 15 ---------------
>>   hw/ide/pci.c         | 25 ++++++++++++++++++++++++-
>>   hw/ide/piix.c        | 19 -------------------
>>   hw/ide/sii3112.c     |  3 ++-
>>   hw/ide/via.c         | 15 ---------------
>>   6 files changed, 26 insertions(+), 52 deletions(-)
>
>
>> diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c
>> index 5dd3d03c29..0af897a9ef 100644
>> --- a/hw/ide/sii3112.c
>> +++ b/hw/ide/sii3112.c
>> @@ -301,9 +301,10 @@ static void sii3112_pci_class_init(ObjectClass *klass, 
>> void *data)
>>       pd->class_id = PCI_CLASS_STORAGE_RAID;
>>       pd->revision = 1;
>>       pd->realize = sii3112_pci_realize;
>> +    pd->exit = NULL;
>>       dc->reset = sii3112_reset;
>> +    dc->vmsd = NULL;
>>       dc->desc = "SiI3112A SATA controller";
>
>The SiI3112A doesn't have these regions?

Yeah, it ignores a lot of stuff in the base class. This gets changed in the 
last part of this series though. This seems why there is no exit method. 
Furthermore -- probably due to additional custom fields -- there is no 
migration description.

Best regards,
Bernhard