Am 14.08.23 um 15:53 schrieb Kevin Wolf: > Am 06.07.2023 um 16:43 hat Paolo Bonzini geschrieben: >> Queued, thanks. > > This patch broke qemu-iotests 109 (for raw images), some block jobs get > now paused once more. This is probably okay, but please double check and > fix either the reference output or the code. >
Sorry about that! AFAICT, the additional pause happens, because the bdrv_drain_all() call in do_vm_stop() is now not inside the drained section used by qemu_cleanup() anymore. I.e., there is a second drained section now that ends before the final one in qemu_cleanup() starts and thus job_pause() is called twice via child_job_drained_begin(). I'll try to wrap my head around 185 too. Best Regards, Fiona
