Am 27.04.2016 um 16:34 hat Eric Blake geschrieben: > On 04/27/2016 03:52 AM, Kevin Wolf wrote: > > It used to be an internal helper function just for implementing > > bdrv_co_do_readv/writev(), but now that it's a public interface, it > > deserves a name without "do" in it. > > > > Signed-off-by: Kevin Wolf <[email protected]>
> > +++ b/hw/ide/macio.c > > @@ -55,8 +55,8 @@ static const int debug_macio = 0; > > /* > > * Unaligned DMA read/write access functions required for OS X/Darwin which > > * don't perform DMA transactions on sector boundaries. These functions are > > - * modelled on bdrv_co_do_preadv()/bdrv_co_do_pwritev() and so should be > > - * easy to remove if the unaligned block APIs are ever exposed. > > + * modelled on bdrv_co_preadv()/bdrv_co_pwritev() and so should be easy to > > + * remove if the unaligned block APIs are ever exposed. > > */ > > Is this comment now stale as a result of your series? No, as I mentioned in the cover letter, bdrv_co_preadv() and bdrv_co_pwritev() still enforce a minimum alignment of 512. The next steps towards using unaligned I/O in macio.c are removing that minimum (which we can now do for all drivers that implement .bdrv_co_preadv/pwritev) and then using these functions in dma-helpers.c. Kevin
pgpkfz6FfVl9W.pgp
Description: PGP signature
